Skip to content

VCF-50: Update region_partition and sample_partition parameter descriptions#869

Merged
alancleary merged 2 commits intomainfrom
alancleary/VCF-50
Jan 16, 2026
Merged

VCF-50: Update region_partition and sample_partition parameter descriptions#869
alancleary merged 2 commits intomainfrom
alancleary/VCF-50

Conversation

@alancleary
Copy link
Copy Markdown
Member

Previously the descriptions described the types of the parameters but not their functions. This PR adds the latter.

@leipzig
Copy link
Copy Markdown
Member

leipzig commented Jan 16, 2026

is idx 0-based or 1-based?

@alancleary
Copy link
Copy Markdown
Member Author

is idx 0-based or 1-based?

@leipzig 0-based. Do you want this mentioned in the descriptions?

@leipzig
Copy link
Copy Markdown
Member

leipzig commented Jan 16, 2026

Yes might as well

@alancleary
Copy link
Copy Markdown
Member Author

Yes might as well

@leipzig Done

Copy link
Copy Markdown

@spirpinias spirpinias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely worded, @alancleary

@alancleary alancleary merged commit 8bbe510 into main Jan 16, 2026
9 checks passed
@alancleary alancleary deleted the alancleary/VCF-50 branch January 16, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants